This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Chunk teacher] Bug with distributed evaluation #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 11:32
wyshi
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Very subtle bug using chunk teacher with distributed evaluation. The count to place samples for different gpus was being reset every time a chunk was being loaded, which led to the wrong number of samples being placed on certain gpus IF the valid set had more than one chunk assigned to it. This led to the system hanging forever at the
self.samples.get(), becausenum_episodesexceeded the actual number of samples on the queue.💀 RIP a day of my life 💀