This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Observation: parse args from cmd won't override the param (see from From the prints of #2933 (review)
) as intended, plus NO
Parse Error: unrecognized arguments:
.Command to reproduce:
parlai interactive -mf {model_file_path} --beam-context_block_ngram 10
No overrides WARNING.
Instead, if one runs
parlai interactive -mf {model_file_path} --beam-context-block-ngram 10
,the params were overriden as expected.
Testing steps
CI
Logs