-
Notifications
You must be signed in to change notification settings - Fork 449
Conversation
Hi @Illcat! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This looks good to me, I'll merge it shortly!
@lw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@illcat has updated the pull request. You must reimport the pull request before landing. |
Please approve. @lw |
@lw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@illcat has updated the pull request. You must reimport the pull request before landing. |
I merged your changes to the delimiter but I didn't pick up your other changes. Could you submit another PR with those? Thanks |
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist