Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

add delimiter and transpose #198

Closed
wants to merge 3 commits into from
Closed

add delimiter and transpose #198

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot
Copy link
Contributor

Hi @Illcat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2021
Copy link
Contributor

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks good to me, I'll merge it shortly!

@facebook-github-bot
Copy link
Contributor

@lw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@illcat has updated the pull request. You must reimport the pull request before landing.

@ghost
Copy link
Author

ghost commented Mar 28, 2021

Please approve. @lw

@facebook-github-bot
Copy link
Contributor

@lw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@illcat has updated the pull request. You must reimport the pull request before landing.

@ghost ghost changed the title custom separator add delimiter and transpose Mar 29, 2021
@ghost ghost mentioned this pull request Mar 29, 2021
7 tasks
@facebook-github-bot
Copy link
Contributor

@lw merged this pull request in e63485a.

@lw
Copy link
Contributor

lw commented Mar 29, 2021

I merged your changes to the delimiter but I didn't pick up your other changes. Could you submit another PR with those? Thanks

@ghost ghost deleted the patch-1 branch March 30, 2021 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants