Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make anchor_generator scriptable #1518

Closed

Conversation

chenbohua3
Copy link
Contributor

This is a refined version of #1483 to make anchor_generator scriptable. Thanks for your work @ppwwyyxx :)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2020
@ppwwyyxx
Copy link
Contributor

Seems like named_buffer is already available with pytorch/pytorch#37905 landed! Let's clean up the hack

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppwwyyxx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Jun 24, 2020
Summary:
This is a refined version of #1483  to make anchor_generator scriptable. Thanks for your work ppwwyyxx :)
Pull Request resolved: #1518

Reviewed By: rbgirshick

Differential Revision: D22213759

Pulled By: ppwwyyxx

fbshipit-source-id: 5796548e4cd33dedd3d09de0f8ab03ea032bb7c9
@chenbohua3 chenbohua3 deleted the anchor_generator branch July 10, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants