Update dlrm_data_pytorch.py #169
Conversation
There is a typo in dlrm_data_pytorch.py when --mlperf-bin-loader flag is used.
Traceback (most recent call last):
File "dlrm_s_pytorch.py", line 1869, in <module>
run()
File "dlrm_s_pytorch.py", line 1080, in run
train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args)
File "/workspace/dlrm/dlrm_data_pytorch.py", line 445, in make_criteo_data_and_loaders
value=train_data.num_samples)
AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'
Traceback (most recent call last):
File "dlrm_s_pytorch.py", line 1869, in <module>
run()
File "dlrm_s_pytorch.py", line 1080, in run
train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args)
File "/workspace/dlrm/dlrm_data_pytorch.py", line 467, in make_criteo_data_and_loaders
value=test_data.num_samples)
AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'
I changed it to 'value=train_data.num_entries' and that seemed to work.
|
Hi @jplewis2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Can you please sign CLA https://code.facebook.com/cla for us to review it? |
Was getting a couple errors when using the
--mlperf-bin-loaderparameter.Traceback (most recent call last): File "dlrm_s_pytorch.py", line 1869, in <module> run() File "dlrm_s_pytorch.py", line 1080, in run train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args) File "/workspace/dlrm/dlrm_data_pytorch.py", line 445, in make_criteo_data_and_loaders value=train_data.num_samples) AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'Traceback (most recent call last): File "dlrm_s_pytorch.py", line 1869, in <module> run() File "dlrm_s_pytorch.py", line 1080, in run train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args) File "/workspace/dlrm/dlrm_data_pytorch.py", line 467, in make_criteo_data_and_loaders value=test_data.num_samples) AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'I changed
num_samplestonum_entriesand that seemed to work as intended.