Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dlrm_data_pytorch.py #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Mar 15, 2021

  1. Update dlrm_data_pytorch.py

    There is a typo in dlrm_data_pytorch.py when --mlperf-bin-loader flag is used.
    
    Traceback (most recent call last):
      File "dlrm_s_pytorch.py", line 1869, in <module>
        run()
      File "dlrm_s_pytorch.py", line 1080, in run
        train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args)
      File "/workspace/dlrm/dlrm_data_pytorch.py", line 445, in make_criteo_data_and_loaders
        value=train_data.num_samples)
    AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'
    
    Traceback (most recent call last):
      File "dlrm_s_pytorch.py", line 1869, in <module>
        run()
      File "dlrm_s_pytorch.py", line 1080, in run
        train_data, train_ld, test_data, test_ld = dp.make_criteo_data_and_loaders(args)
      File "/workspace/dlrm/dlrm_data_pytorch.py", line 467, in make_criteo_data_and_loaders
        value=test_data.num_samples)
    AttributeError: 'CriteoBinDataset' object has no attribute 'num_samples'
    
    I changed it to 'value=train_data.num_entries' and that seemed to work.
    jplewis2 authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e612440 View commit details
    Browse the repository at this point in the history