Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requires_grad check for params_with_grad method #1171

Conversation

whbldhwj
Copy link

What does this PR do?

This PR fixes the silent errors of params_with_grad when param.requires_grad=False.

Before the fix, if we have params with requires_grad=False, when we call params_with_grad method (e.g., from gradient clipping:

  • the original code first checks that p.grad is not None is evaluated to False
  • then it tries to evaluate p.main_grad is not None. Since p doesn't have the main_grad attribute, this line of code will error out. When the outside caller doesn't catch this exception properly, this will lead to potential bugs.

For the fix, we added requires_grad check before the rest of the code.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2024
@whbldhwj whbldhwj requested a review from jiecaoyu March 25, 2024 18:55
@whbldhwj whbldhwj merged commit 1307b1d into ngoyal_changes_for_pp_fp8_jiecaoyu_free_fp16_shard Mar 25, 2024
1 of 18 checks passed
@whbldhwj whbldhwj deleted the ngoyal_changes_for_pp_fp8_jiecaoyu_free_fp16_shard_jie_fix branch March 25, 2024 20:14
chrisxcai pushed a commit that referenced this pull request May 15, 2024
Co-authored-by: Jie Wang <jiewang@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants