Added requires_grad check for params_with_grad method #1171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the silent errors of
params_with_grad
whenparam.requires_grad=False
.Before the fix, if we have params with
requires_grad=False
, when we callparams_with_grad
method (e.g., from gradient clipping:p.grad is not None
is evaluated to Falsep.main_grad is not None
. Since p doesn't have the main_grad attribute, this line of code will error out. When the outside caller doesn't catch this exception properly, this will lead to potential bugs.For the fix, we added
requires_grad
check before the rest of the code.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.