Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder CMake Python binding dependencies #192

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Reorder CMake Python binding dependencies #192

merged 1 commit into from
Nov 28, 2023

Conversation

cbalioglu
Copy link
Contributor

This PR changes the CMake dependency order for the Python C extension library to avoid header file conflicts with PyTorch. See #170, #152.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2023
@cbalioglu
Copy link
Contributor Author

cc @ezyang

@cbalioglu cbalioglu merged commit f4d0b7e into main Nov 28, 2023
16 checks passed
@cbalioglu cbalioglu deleted the fmt branch November 28, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbalioglu @facebook-github-bot