Skip to content

Commit

Permalink
Remove unused variables in faiss/IndexIVFFastScan.cpp (#3439)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #3439

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje, junjieqi

Differential Revision: D57344013

fbshipit-source-id: adf410139d2e6ca69a26ccdbff8511c9b7620489
  • Loading branch information
r-barnes authored and facebook-github-bot committed May 15, 2024
1 parent 558a7c3 commit b8e4489
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions faiss/IndexIVFFastScan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -914,10 +914,6 @@ void IndexIVFFastScan::search_implem_10(
size_t* nlist_out,
const NormTableScaler* scaler,
const IVFSearchParameters* params) const {
const size_t max_codes = params ? params->max_codes : this->max_codes;
const SearchParameters* quantizer_params =
params ? params->quantizer_params : nullptr;

size_t dim12 = ksub * M2;
AlignedTable<uint8_t> dis_tables;
AlignedTable<uint16_t> biases;
Expand Down
1 change: 0 additions & 1 deletion tutorial/cpp/6-HNSW.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ int main() {
xq[d * i] += i / 1000.;
}

int nlist = 100;
int k = 4;

faiss::IndexHNSWFlat index(d, 32);
Expand Down

0 comments on commit b8e4489

Please sign in to comment.