Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Print n-gram vectors #289

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

englhardt
Copy link

Extension of print-ngrams to extract multiple n-gram vectors at once. Work around until a real solution is added to circumvent the hashing problem.
Issues: #21, #121, #282

@bzz
Copy link

bzz commented Aug 14, 2017

--help might need to be updated as well.

One more thing - on a supervised trained mode, this command prints first the word vector and only then the n-grams. Out of vocabulary word vector in this case becomes all 0, which if I'm not mistaken, seems to be inconsistent with print-word-vectors behavior.

@englhardt
Copy link
Author

@bzz Thanks. I updated the help commands.

For your second point, I only adopted the current behavior of print-ngrams, i.e. method ngramVectors(...). I suggest fixing this in another PR.

@bzz
Copy link

bzz commented Jan 8, 2018

@englhardt makes sense. Seems like rebase is also needed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants