Switch FMM formulations to new implementation #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a further step to addressing #55
The hyperparameters (smoothness loss weight and fourier loss weight) were adjusted to achieve good convergence of simulated quantities with the number of Fourier terms in the expansion. For the uLED, this new implementation gives essentially unchanged results when compared to the earlier implementation (see figure).
The old implementations still remain in the code; these should be removed in a follow-up PR.