Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Stop should be action 0 #21

Closed
mathfac opened this issue Apr 3, 2019 · 0 comments
Closed

Suggestion: Stop should be action 0 #21

mathfac opened this issue Apr 3, 2019 · 0 comments
Labels
question Further information is requested

Comments

@mathfac
Copy link
Contributor

mathfac commented Apr 3, 2019

Author @danielgordon10:

https://github.com/fairinternal/habitat-api/blob/9fe6fbf2249d1a9c675d1eb2e79327616df0a4b4/habitat/sims/habitat_simulator.py#L128

When people add new actions they will go below the ones we already have. It would be weird for "stop" to be in the middle. It would also be weird to have stop be the "last" value which would always change if people add more actions.
@mathfac mathfac added the question Further information is requested label Apr 3, 2019
dhruvbatra pushed a commit that referenced this issue May 10, 2020
@erikwijmans
Exposes the subclasses used for {Mp3d, Suncg}SemanticScene (#21)
8ee3eb4 
* Exposes the subclasses used for {Mp3d, Suncg}SemanticScene

* Add header

* Bind lambda

* Tests, as promissed

* Fix nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathfac @erikwijmans