Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an ipython notebook illustrating simple use cases #106

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

bhavanajain
Copy link

@bhavanajain bhavanajain commented Jun 6, 2019

Motivation and Context

The habitat-api-demo.ipynb notebook illustrates how to specify config parameters, print semantic annotations of a scene. It also visualises the RGB, semantic and depth observations obtained by executing a random sequence of actions.
TODO: Add a code block to walk along a shortest path and visualise observations along the way.

It's a beginner's tutorial :)

How Has This Been Tested

This has been tested using the nbval plugin in pytest with the --nbval-lax option. Details are in test/test_demo_notebook.py. There is a conditional skip in case dataset or scenes are not present.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 6, 2019
@erikwijmans
Copy link
Contributor

Can you reduce the number of prints in the printing of the scene graph? Just only print the first 15 things or so then exit.

@erikwijmans
Copy link
Contributor

Also looks like you'll need to do the same thing of skipping the notebook in the CI :)

Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for brining notebook example and testing for that. It will help to keep it up to date with new changes and scale it to new notebooks we will have.

@mathfac mathfac merged commit 969e853 into master Jun 7, 2019
@mathfac mathfac deleted the example_notebook branch June 7, 2019 00:04
dhruvbatra pushed a commit that referenced this pull request May 10, 2020
* assets: use a multiplatform Corrade::Utility::Directory::mapRead().

It has a RAII interface, so no need for explicit unmapping there. Also
made the code more const.

* gfx: use Corrade's platform defines for reliable documented behavior.

It ensures that CORRADE_TARGET_WINDOWS is always defined on Windows.
Additionally, I switched to CORRADE_TARGET_UNIX from __linux__ (after
excluding CORRADE_TARGET_APPLE) because there's BSD too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants