Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precommit and fix linter #433

Merged
merged 10 commits into from Jul 28, 2020
Merged

Update precommit and fix linter #433

merged 10 commits into from Jul 28, 2020

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Fixes the isort linter issues since the newer version of isort has slightly different standards.
  • Also added some new precommit hooks to help keep the repo clean.

Checklist

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #433 into master will decrease coverage by 0.00%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   76.32%   76.31%   -0.01%     
==========================================
  Files         108      108              
  Lines        7665     7664       -1     
==========================================
- Hits         5850     5849       -1     
  Misses       1815     1815              
Impacted Files Coverage Δ
habitat/core/benchmark.py 47.94% <0.00%> (ø)
habitat_baselines/agents/slam_agents.py 0.00% <0.00%> (ø)
habitat/core/utils.py 52.00% <100.00%> (ø)
habitat/core/vector_env.py 80.00% <100.00%> (ø)
habitat/sims/habitat_simulator/__init__.py 56.25% <100.00%> (ø)
habitat_baselines/common/utils.py 79.10% <100.00%> (ø)
habitat_baselines/rl/ddppo/algo/ddp_utils.py 62.02% <100.00%> (ø)
habitat_baselines/rl/ddppo/algo/ddppo.py 67.50% <100.00%> (ø)
habitat_baselines/rl/ddppo/algo/ddppo_trainer.py 78.57% <100.00%> (ø)
habitat_baselines/rl/ddppo/policy/resnet.py 68.90% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c74db...2acc9c6. Read the comment docs.

@Skylion007 Skylion007 merged commit 0a57aec into master Jul 28, 2020
@Skylion007 Skylion007 deleted the precommit_fixes branch July 28, 2020 19:02
srama2512 pushed a commit that referenced this pull request Mar 15, 2023
Fixed seeding to work as desired
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants