-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config system improvements: compositional config, added scenes_dir, removed config_dir, fixed eqa test #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made simple agents suitable for challenge submissions.
Removed .swp file, added swp to gitignore.
Update docker
Adding arxiv identifier
mathfac
requested review from
msavva,
abhiskk,
apsdehal,
jia-git and
erikwijmans
April 28, 2019 02:01
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Apr 28, 2019
erikwijmans
suggested changes
Apr 28, 2019
habitat/config/default.py
Outdated
def get_config( | ||
config_file: Optional[str] = None, config_dir: str = DEFAULT_CONFIG_DIR | ||
) -> CN: | ||
def get_config(config_file: Optional[str] = None) -> CN: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment/feelings about this function as above.
… options, added EQA dataset changes, adopted quaternion suggestion
Addressed the comments. Added support of config list, corrected scene_path, added overwriting options, added EQA dataset changes, adopted quaternion suggestion. Retested:
|
erikwijmans
approved these changes
Apr 30, 2019
This was referenced Apr 30, 2019
brucecui97
pushed a commit
to brucecui97/habitat-api
that referenced
this pull request
May 16, 2019
…emoved config_dir, fixed eqa test (facebookresearch#77) * Added scenes_dir parameter to Config to have no requirement of data symlink or data directory in working directory. scenes_dir will be used as prefix for scene_id during episodes dataset loading. * Added overwriting options argument to get_config that unblocks parameter sweeping and experimentation capabilities from command line * config_file path can be comma separated list of configs that will be merged in exact order. That will help to use separate configs for dataset specification and sensors setups. String with commas was chosen because that make it easy to pass list of configs as script argument. * To make habitat-api easier to as package we decided to get rid of forcing loading of configs from config_dir param * fixed unit test caused by latest habitat-sim update * Added support of config list, corrected scene_path, added overwriting options, added EQA dataset changes, adopted quaternion suggestion * Fixed headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scenes_dir
parameter to Config to have no requirement ofdata
symlink or data directory in working directory.scenes_dir
will be used as prefix forscene_id
during episodes dataset loading.get_config
that unblocks parameter sweeping and experimentation capabilities from command lineconfig_file
path can be comma separated list of configs that will be merged in exact order. That will help to use separate configs for dataset specification and sensors setups. String with commas was chosen because that make it easy to pass list of configs as script argument.config_dir
paramCaution: with this change all config paths will be specified in new way:
tasks/poingoal.yaml
=>configs/tasks/pointgoal.yaml
How Has This Been Tested
pytest
black . --line-length 79;mypy . --ignore-missing-imports;pycodestyle;flake8
Types of changes
Checklist