Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix missing reserve call for std::vector for ManagedContainer #1425

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[bugfix] Fix missing reserve call for std::vector for ManagedContainer #1425

merged 1 commit into from
Aug 5, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Minor Perf Bugfix

How Has This Been Tested

  • CI / Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 5, 2021
@Skylion007 Skylion007 changed the title Fix missing reserve call for std::vector for ManagedContainer [bugfix] Fix missing reserve call for std::vector for ManagedContainer Aug 5, 2021
jturner65
jturner65 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 merged commit 89b6273 into master Aug 5, 2021
@Skylion007 Skylion007 deleted the ContainerManaged-FixReserveRes branch August 5, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot