Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TechDebt]--JsonAttributes Docs update #1486

Merged
merged 6 commits into from
Sep 21, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR is updating the attributesJSON, which is currently out of date, to match the currently supported fields for the various configuration types. Still a work in progress. This is the first of many documentation PRs to cover the MetadataMediator/SceneDataset/SceneInstance system.

How Has This Been Tested

Docs build

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 16, 2021
@jturner65 jturner65 force-pushed the Attr_DocsUpdate branch 4 times, most recently from 528d03d to 6067102 Compare September 20, 2021 14:25
@jturner65 jturner65 changed the title [WIP][TechDebt]--JsonAttributes Docs update [TechDebt]--JsonAttributes Docs update Sep 21, 2021
@jturner65 jturner65 marked this pull request as ready for review September 21, 2021 14:25
@jturner65 jturner65 merged commit 0cf2628 into facebookresearch:main Sep 21, 2021
@jturner65 jturner65 deleted the Attr_DocsUpdate branch September 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants