Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for Imgui assert on hiding FPS display #1521

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Bugfix for Imgui assert on hiding FPS display #1521

merged 1 commit into from
Oct 7, 2021

Conversation

eundersander
Copy link
Contributor

Motivation and Context

Misplaced Imgui::End. Repro this by hiding the FPS display with the c key.

How Has This Been Tested

Local testing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 6, 2021
@eundersander eundersander force-pushed the eundersander/viewer_hide_fps_fix branch from 197dba8 to 34c1e9f Compare October 7, 2021 14:43
@eundersander eundersander merged commit 867cd8a into facebookresearch:main Oct 7, 2021
@eundersander eundersander deleted the eundersander/viewer_hide_fps_fix branch October 7, 2021 16:23
JuanTheEngineer pushed a commit that referenced this pull request Oct 8, 2021
@eundersander @JuanTheEngineer
fix for imgui assert on hiding FPS display (#1521)
ac84dd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eundersander @jturner65 @Skylion007 @facebook-github-bot