Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Add keymap to display current scene dataset report #1543

Merged
merged 1 commit into from
Oct 21, 2021
Merged

--Add keymap to display current scene dataset report #1543

merged 1 commit into from
Oct 21, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This tiny PR adds a keymapping to display the currently loaded scene dataset's detail report to the console.

How Has This Been Tested

It's viewer! It always works! Run locally to verify it works.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 21, 2021
aclegg3
aclegg3 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JuanTheEngineer
JuanTheEngineer approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@JuanTheEngineer JuanTheEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@jturner65 jturner65 merged commit c3f15f3 into facebookresearch:main Oct 21, 2021
@jturner65 jturner65 deleted the ViewerDatasetReport branch October 21, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@JuanTheEngineer JuanTheEngineer JuanTheEngineer approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jturner65 @aclegg3 @JuanTheEngineer @facebook-github-bot