Properly propagate errors from the build shell scripts #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI happily continues running pytest even if the build fails. That is *not* wanted.
facebook-github-bot
added
the
CLA Signed
msbaines
approved these changes
Aug 19, 2019
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
facebookresearch#159) Added installation requirements step for sim installation in CI setup
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
…earch#153) * refactor and add generic trainer class * fix to pass tests * change BaseModel to BaseTrainer * fix tensorboard import causing CI failure * modify circle-ci test script accordingly * doc, typing and other changes * rename BASELINE to TRAINER * merge from upstream master * Update Habitat-API to allow for no rendering sensors (facebookresearch#139) Update Habitat-API to allow for no rendering sensors * Added installation requirements step for sim installation in CI setup. (facebookresearch#159) Added installation requirements step for sim installation in CI setup * move RolloutStorage to utils * add environments.py * make ckpt dir if not exist * small fixes according to comments * changes according to comments * update readme * fix old config compatibility * fix missed isort lint
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
…arch#159) The CI happily continues running pytest even if the build fails. That is *not* wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The CI happily continued running pytest even if the C++ build failed. That is not wanted.
How Has This Been Tested
It no longer succeeds when it should fail, while it still succeeds when it should succeed.