Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Remove SUNCG dataset support/references #1591

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR removes all support and references to SunCG dataset, to minimize clutter and potential for future support issues as we refactor and update mesh loading pipeline and support for semantic assets, dataset configs, etc.

How Has This Been Tested

locally c++ and python. Suncg test was removed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 8, 2021
@jturner65 jturner65 merged commit f76b2a6 into facebookresearch:main Dec 9, 2021
@jturner65 jturner65 deleted the Suncg_removal branch December 9, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants