Revive the C++ tests, make them pass and enable them on the CI #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And disable tests for gflags -- we don't want these to run.
GCC has issues with those:
SimTest.cpp:26:41: sorry, unimplemented: non-trivial designated initializers not supported
We can't use them on the CI but we still want the tests to be run.
facebook-github-bot
added
the
CLA Signed
msbaines
approved these changes
Aug 19, 2019
erikwijmans
approved these changes
Aug 19, 2019
erikwijmans
approved these changes
Aug 19, 2019
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
* Add fog-of-war to topdown map
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
…ookresearch#160) * CMake: run tests using CTest. And disable tests for gflags -- we don't want these to run. * Use absolute paths to test files in the tests. * Execute CTest in build.sh, enable tests on the CI. * tests: don't use C designated initializers. GCC has issues with those: SimTest.cpp:26:41: sorry, unimplemented: non-trivial designated initializers not supported * tests: skip a test if (licensed) datasets are not found. We can't use them on the CI but we still want the tests to be run. * tests: reduce verbosity of some loud tests. * tests: srsly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
GTEST_SKIP())How Has This Been Tested
Passes locally and on the CI, moreover the CI output now contains also the CTest log.