Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Update Magnum to most recent version #1619

Merged
merged 1 commit into from
Jan 12, 2022
Merged

--Update Magnum to most recent version #1619

merged 1 commit into from
Jan 12, 2022

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Jan 12, 2022 •
edited

Motivation and Context

This PR updates Magnum deps to add SceneTools and support for scene and mesh utilities.

How Has This Been Tested

Locally c++ and python

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65
--update magnum to most recent version
7d684c6 
Adds Magnum SceneData, and support for scene and mesh utilities.
@jturner65 jturner65 requested a review from mosra January 12, 2022 17:24
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 12, 2022
@jturner65 jturner65 changed the title --update Magnum to most recent version --Update Magnum to most recent version Jan 12, 2022
mosra
mosra approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, it works!

@jturner65 jturner65 merged commit 08be9bd into facebookresearch:main Jan 12, 2022
@jturner65 jturner65 deleted the update_magnum branch January 12, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jturner65 @mosra @Skylion007 @facebook-github-bot