Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hsim js bindings build to CircleCI. #166

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Add hsim js bindings build to CircleCI. #166

merged 1 commit into from
Aug 21, 2019

Conversation

msbaines
Copy link
Contributor

@msbaines msbaines commented Aug 20, 2019

Motivation and Context

  • Add javascript binding build to CircleCI in order to prevent breakages of emscripten build.
  • To enable this, I needed to add logic in build_js.sh to build corrade-rc.

How Has This Been Tested

CircleCI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 20, 2019
@msbaines msbaines requested review from mathfac, msavva and mosra and removed request for mosra, msavva and mathfac August 20, 2019 20:19
build_js.sh Outdated Show resolved Hide resolved
@msbaines msbaines force-pushed the em-buildbot branch 3 times, most recently from 5d5c626 to 114ce55 Compare August 21, 2019 20:46
@msbaines
Copy link
Contributor Author

It is now passing and all feedback should be addressed.

Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msbaines thank you for adding JS build step to CI, that's important part of new functionality reliability. Small comment, overall looks great.

.circleci/config.yml Outdated Show resolved Hide resolved
build_js.sh Show resolved Hide resolved
@@ -192,14 +203,22 @@ jobs:
export PYTHONPATH=$PYTHONPATH:$(pwd)
GTEST_COLOR=yes ./build.sh --headless --run-tests
pytest
- run:
Copy link
Contributor

@mathfac mathfac Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step increases whole testing for 4 min. Unfortunately, when background: true option is used step can't fail the testing and is considered successful. Let's keep it as is right now and parallelize later when we have more understanding what other tests we will run for JS build, physics, C++.

@msbaines msbaines merged commit 7edf606 into master Aug 21, 2019
@msbaines msbaines deleted the em-buildbot branch August 21, 2019 23:47
eundersander pushed a commit to eundersander/habitat-sim that referenced this pull request Aug 6, 2020
…ch#166)

* Make fog-of-war darker and make that value changeable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants