-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hsim js bindings build to CircleCI. #166
Conversation
5d5c626
to
114ce55
Compare
It is now passing and all feedback should be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msbaines thank you for adding JS build step to CI, that's important part of new functionality reliability. Small comment, overall looks great.
@@ -192,14 +203,22 @@ jobs: | |||
export PYTHONPATH=$PYTHONPATH:$(pwd) | |||
GTEST_COLOR=yes ./build.sh --headless --run-tests | |||
pytest | |||
- run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step increases whole testing for 4 min. Unfortunately, when background: true
option is used step can't fail the testing and is considered successful. Let's keep it as is right now and parallelize later when we have more understanding what other tests we will run for JS build, physics, C++.
…ch#166) * Make fog-of-war darker and make that value changeable
Motivation and Context
How Has This Been Tested
CircleCI
Types of changes
Checklist