Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant clang-tidy check (google-make-explicit-pair) #1661

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

Skylion007
Copy link
Contributor

@Skylion007 Skylion007 commented Feb 12, 2022

Motivation and Context

@jturner65 Pointed on there was a check turned on for clang-tidy that really should not have been enabled. It does not serve any purpose as it targets a bug gcc 4.6, I have disabled the clang-tidy check in the config.

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 12, 2022
@Skylion007 Skylion007 mentioned this pull request Feb 12, 2022
11 tasks
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. LGTM

@Skylion007 Skylion007 merged commit 52d528c into main Feb 13, 2022
@Skylion007 Skylion007 deleted the remove-unnecessary-clang-tidy-make-pair branch February 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants