Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Manipulator Bug Fix #1700

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Conversation

ASzot
Copy link
Contributor

@ASzot ASzot commented Mar 20, 2022

Motivation and Context

This PR fixes two issues:

  1. The mobile manipulator joint creation was incorrect. The arm joint parameters were being applied to all joints rather than just the arm joints. The default motor parameters should be applied to the non-arm and non-base parameters. Fixing this bug results in much more stable arm movement.
  2. The head camera offset was too small, so that when the robot moved around, the head camera would be occluded by the head geometry.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 20, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense.

Looks like the gripper open test is failing, maybe because it used to have arm motor settings and now has default settings?

Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When tests pass, let's merge.

@aclegg3 aclegg3 merged commit 482b46e into facebookresearch:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants