Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Rigid Object Instance Non-uniform scaling #1742

Merged
merged 2 commits into from
May 4, 2022

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented May 3, 2022

Motivation and Context

This PR adds SceneObjectInstance support of non-uniform scaling. Coupled with the existing online support of modifying scale via setting stage or object config attributes, non-uniform scaling capabilities can be provided to the user. Note : this scaling is only available before instantiation - once an object is instantiated, the scale is set and unmodifiable (as is the existing paradigm for scale).

Please also see this PR for an alternative, online approach to nonuniform scaling.

How Has This Been Tested

Existing c++ and python tests pass. C++ tests added to verify appropriate load from json and save to json file for new fields.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 3, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aclegg3 aclegg3 merged commit b75d11c into facebookresearch:main May 4, 2022
@aclegg3 aclegg3 deleted the ObjectInstanceScale branch May 4, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants