Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin toml-sort version to fix pre-commit issue on CI. #1983

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Pin toml-sort version to fix pre-commit issue on CI. #1983

merged 1 commit into from
Jan 9, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jan 8, 2023

Motivation and Context

This pins toml-sort to a specific version to fix a pre-commit CI issue.
The same fix was applied to lab here: facebookresearch/habitat-lab#1063

How Has This Been Tested

Tested on CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 8, 2023
@0mdc 0mdc changed the title Pin toml-sort version to fix pre-commit issuse on CI. Pin toml-sort version to fix pre-commit issue on CI. Jan 8, 2023
vincentpierre
vincentpierre approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0mdc 0mdc merged commit 7327002 into main Jan 9, 2023
@0mdc 0mdc deleted the toml-sort-ci-fix branch January 9, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@vincentpierre vincentpierre vincentpierre approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0mdc @Skylion007 @vincentpierre @facebook-github-bot