Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Human Armature into Downloader #2016

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Add Human Armature into Downloader #2016

merged 2 commits into from
Feb 28, 2023

Conversation

xavierpuigf
Copy link
Contributor

Motivation and Context

Downloads human armature assets, required to control humanoid agent in Habitat

How Has This Been Tested

Tested the download script

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 24, 2023
@xavierpuigf xavierpuigf mentioned this pull request Feb 28, 2023
Merged
7 tasks
aclegg3
aclegg3 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavierpuigf xavierpuigf merged commit 9ae69a6 into main Feb 28, 2023
@jturner65 jturner65 deleted the new_download_humanoid branch November 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xavierpuigf @aclegg3 @facebook-github-bot