Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Spot mesh #2023

Merged
merged 1 commit into from
Mar 1, 2023
Merged

update Spot mesh #2023

merged 1 commit into from
Mar 1, 2023

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

The PR updates Spot mesh appearance. The previous PR uses the factory default color: https://github.com/facebookresearch/habitat-sim/commit/58921deb970177aa312beda4518a137473202ace

How Has This Been Tested

interactive_play.py can load Spot robot correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 1, 2023
@jimmytyyang jimmytyyang requested a review from aclegg3 March 1, 2023 20:41
@jimmytyyang
Copy link
Contributor Author

The urdf asset has been uploaded to AWS S3. thank you!

@dhruvbatra
Copy link
Contributor

Awesome! Blue Habitat logo 😄

@aclegg3
Copy link
Contributor

aclegg3 commented Mar 1, 2023

The urdf asset has been uploaded to AWS S3. thank you!

Thanks Jimmy, looks good. We can merge.
Can you re-upload to S3 after stripping OSX "._DS_Store" junk files?
See https://ss64.com/osx/dot_clean.html
Or on linux: find . -type f -name '._*' -exec rm {} +

@jimmytyyang
Copy link
Contributor Author

Thanks, Alex! I cleaned up the folder. Thank you for the quick review!

@jimmytyyang jimmytyyang merged commit b6186aa into main Mar 1, 2023
@jturner65 jturner65 deleted the spot_mesh_update branch November 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimmytyyang @dhruvbatra @aclegg3 @facebook-github-bot