Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build CI issue with git commands. #2146

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jul 3, 2023

Motivation and Context

This fixes an ongoing CI issue with Linux conda_build_binaries that was probably caused by an automated update of a git dependency.

Error:

Traceback (most recent call last):
  File "/remote/habitat-sim/conda-build/matrix_builder.py", line 160, in <module>
    main()
  File "/remote/habitat-sim/conda-build/matrix_builder.py", line 142, in main
    sha = repo.head.object.hexsha
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/refs/symbolic.py", line 219, in _get_object
    return Object.new_from_sha(self.repo, hex_to_bin(self.dereference_recursive(self.repo, self.path)))
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/objects/base.py", line 94, in new_from_sha
    oinfo = repo.odb.info(sha1)
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/db.py", line 40, in info
    hexsha, typename, size = self._git.get_object_header(bin_to_hex(binsha))
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/cmd.py", line 1383, in get_object_header
    return self.__get_object_header(cmd, ref)
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/cmd.py", line 1370, in __get_object_header
    return self._parse_object_header(cmd.stdout.readline())
  File "/opt/conda/envs/py39/lib/python3.9/site-packages/git/cmd.py", line 1329, in _parse_object_header
    raise ValueError("SHA could not be resolved, git returned: %r" % (header_line.strip()))
ValueError: SHA could not be resolved, git returned: b''

How Has This Been Tested

Tested on CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 3, 2023
@0mdc 0mdc requested a review from aclegg3 July 3, 2023 14:58
@0mdc 0mdc marked this pull request as ready for review July 3, 2023 14:59
@0mdc 0mdc changed the title Fix conda build CI issue with issuing git commands. Fix conda build CI issue with git commands. Jul 3, 2023
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@0mdc 0mdc merged commit 546f7a1 into main Jul 3, 2023
10 checks passed
@0mdc 0mdc deleted the ci-conda-build-git-fix branch July 3, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants