--[BugFix] Get rid of double JSON lookups using HasMember #2182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Using HasMember and then subsequently accessing a JSON value does a double lookup in the JSON document string. Using FindMember will provide an iterator pointing to the desired value or the end of the document if not found.
This PR replaces HasMember lookups with iterator-based FindMember ones. Note : those that remain in URDFParser and SceneDatasetAttributesManager will be removed in the Articulated Object Attributes/Manager PR.
How Has This Been Tested
All Tests in c++ and python pass locally
Types of changes
Checklist