Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BugFix] Get rid of double JSON lookups using HasMember #2182

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Using HasMember and then subsequently accessing a JSON value does a double lookup in the JSON document string. Using FindMember will provide an iterator pointing to the desired value or the end of the document if not found.

This PR replaces HasMember lookups with iterator-based FindMember ones. Note : those that remain in URDFParser and SceneDatasetAttributesManager will be removed in the Articulated Object Attributes/Manager PR.

How Has This Been Tested

All Tests in c++ and python pass locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Use Iterator-based FindMember instead.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 9, 2023
@jturner65 jturner65 merged commit 435d942 into main Aug 9, 2023
10 checks passed
@jturner65 jturner65 deleted the Bugfix_ImproveJSONAccess branch August 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants