Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add details for getting hssd from datasets_downloader #2193

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[docs] Add details for getting hssd from datasets_downloader #2193

merged 2 commits into from
Aug 29, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 22, 2023

Motivation and Context

Updating DATASETS.md to provide downloader info for HSSD.

How Has This Been Tested

NA

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 22, 2023
msavva
msavva approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@msavva msavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@aclegg3 aclegg3 merged commit 6f46bcc into main Aug 29, 2023
@aclegg3 aclegg3 deleted the hssd-datasets-readme-downloader branch August 29, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msavva msavva msavva approved these changes

@dhruvbatra dhruvbatra dhruvbatra approved these changes

@mukulkhanna mukulkhanna mukulkhanna approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aclegg3 @msavva @dhruvbatra @mukulkhanna @facebook-github-bot