Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE Week] Articulated Object Loading refactors and cleanup #2291

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Jan 3, 2024

Motivation and Context

This PR introduces some cleanup and essential prerequisite work for the upcoming support for Non-uniform scaling for Articulated Objects.

  • A scene instance boolean is introduced to specify whether or not to apply the product of the geometric scale vector to the mass for objects and articulated objects.
  • A few functions were refactored to get rid of unconventional or non-descriptive function prototypes
  • A few unused functions were removed.

How Has This Been Tested

All c++ and python tests passed locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 January 3, 2024 18:31
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 3, 2024
Add 'applyScaleToMass' method to determine whether geometric scaling should be applied to mass calc for objects as well as articulated objects
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for isolating refactor PR

@jturner65 jturner65 changed the title --Articulated Object Loading refactors and cleanup --[BE Week] Articulated Object Loading refactors and cleanup Jan 9, 2024
@jturner65 jturner65 merged commit ceb3b3a into main Jan 9, 2024
10 checks passed
@jturner65 jturner65 deleted the AO_NonUniScale_Prework branch January 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants