Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Object/AO creation refactor and Object/AO Instance save/creation #2315

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Feb 2, 2024

Motivation and Context

This PR is intended to address an issue when saving a scene instance, where an AO 's current configuration is not being saved as a SceneAOInstance. In the process this PR also simplifies object/AO creation and makes sure some important processes always take place (which was not formerly the case) such as saving an instance creation attributes upon object/ao creation (and creating a default one if none exists)

How Has This Been Tested

All existing c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

--added suffix to internal-only add
--made final function calls for adding objects and articulated objects protected to govern access.
…points

--Also make sure we always save instance attributes on creation, and create empty ones for objects that do not have them.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 2, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the bug was from another source, but still a nice clean-up pass. 👍
Thanks!

@jturner65 jturner65 marked this pull request as ready for review February 3, 2024 00:46
@jturner65 jturner65 merged commit ad8b289 into main Feb 3, 2024
10 checks passed
@jturner65 jturner65 deleted the AO_Config_InstanceSave branch February 3, 2024 00:46
@jturner65 jturner65 changed the title --[WIP]Object/AO creation refactor and Object/AO Instance save/creation --Object/AO creation refactor and Object/AO Instance save/creation Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants