Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region Query API #2317

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Region Query API #2317

merged 7 commits into from
Feb 6, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 6, 2024

Motivation and Context

Add functions to query region containment for one point and a set of points.

How Has This Been Tested

Added pytests and a demo in viewer.py.

In the below video when the crib object is selected, containing regions are displayed colored by containment percentage. Red is full containment fading to green with less containment. Notice the hues shift as the object is moved between regions.

region_contain-2024-02-05_15.35.34.mp4

Note: this demo will be reverted before merge.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 6, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. See below please

Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor changes, but looks good.

src/esp/scene/SemanticScene.cpp Outdated Show resolved Hide resolved
src/esp/scene/SemanticScene.cpp Outdated Show resolved Hide resolved
src/esp/scene/SemanticScene.h Outdated Show resolved Hide resolved
src/esp/scene/SemanticScene.h Outdated Show resolved Hide resolved
@aclegg3 aclegg3 merged commit 9f7c84e into main Feb 6, 2024
1 of 6 checks passed
@aclegg3 aclegg3 deleted the region-queries branch February 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants