Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized exposure #281

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Optimized exposure #281

merged 1 commit into from
Oct 7, 2019

Conversation

bigbike
Copy link
Contributor

@bigbike bigbike commented Oct 7, 2019

Motivation and Context

The old default value, which is from ReplicaSDK, would cause over-exposure for certain scenes.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bigbike bigbike requested a review from msbaines October 7, 2019 21:26
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 7, 2019
@bigbike bigbike added this to the Replica PTex Rendering Support milestone Oct 7, 2019
@bigbike bigbike merged commit a93a4ed into master Oct 7, 2019
@bigbike bigbike deleted the replica_expo branch October 7, 2019 22:46
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@bigbike
Optimized exposure (facebookresearch#281)
468f412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwijmans erikwijmans erikwijmans approved these changes

@msbaines msbaines Awaiting requested review from msbaines

@mosra mosra Awaiting requested review from mosra

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
Replica PTex Rendering Support
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigbike @erikwijmans @facebook-github-bot