Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger event listener for keys at capturing phase #308

Merged

Conversation

apsdehal
Copy link
Contributor

Motivation and Context

Sometimes users have extensions enabled which override default key behavior. This change intends to fix that behavior by triggering the event listener for keys at the capturing phase so it can't be stopped via event.stopPropagation(). See https://stackoverflow.com/questions/13880126/override-existing-onkeydown-function

How Has This Been Tested

Tested on viewer

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 16, 2019
Copy link
Contributor

@msbaines msbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@apsdehal apsdehal merged commit 6156578 into facebookresearch:master Oct 16, 2019
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
)

- This will help when a user has some extension overriding keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants