Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] enable google-explicit-constructor check #344

Merged
merged 4 commits into from
Nov 11, 2019
Merged

[clang-tidy] enable google-explicit-constructor check #344

merged 4 commits into from
Nov 11, 2019

Conversation

msbaines
Copy link
Contributor

@msbaines msbaines commented Nov 8, 2019

This should help us avoid nasty implicit conversion bugs.

Motivation and Context

Turn on more clang-tidy checks

How Has This Been Tested

Build.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

[clang-tidy] enable google-explicit-constructor check
c6ef7bb 
This should help us avoid nasty implicit conversion bugs.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 8, 2019
msavva
msavva reviewed Nov 10, 2019
View reviewed changes
Copy link
Collaborator

@msavva msavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo in commit. Otherwise, LGTM! 👍

src/esp/gfx/WindowlessContext.cpp Outdated
@@ -71,7 +71,8 @@ bool isNvidiaGpuReadable(int device) {
}

struct ESPEGLContext : ESPContext {
ESPEGLContext(int device) : magnumGlContext_{NoCreate}, gpuDevice_{device} {
explcit ESPEGLContext(int device)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: explcit -> explicit

mathfac
mathfac approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with CI passing condition.

@msbaines msbaines merged commit 9af1f62 into master Nov 11, 2019
@msbaines msbaines deleted the explicit-constructor branch November 11, 2019 23:08
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@msbaines
[clang-tidy] enable google-explicit-constructor check (facebookresear…
e1b74ac 
…ch#344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msavva msavva msavva left review comments

@mathfac mathfac mathfac approved these changes

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msbaines @msavva @mathfac @facebook-github-bot