Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported objects configurable scaling #428

Merged
merged 12 commits into from
Jan 17, 2020
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jan 14, 2020

Motivation and Context

This change allows non-uniform scaling of objects via configuration of an object's template in ResourceManager::physicsObjectLibrary_.

This will allow users to load a single object template and spawn multiple instances with varying scales into the scene.

Note: negative scales are allowed, tested, and stable. Visually, this can invert the mesh normals, allowing the camera to see through the surface of the object due to back-face culling. I didn't restrict this since it could be considered a feature (e.g. invert the scale to see inside a shape from the outside).

How Has This Been Tested

New C++ CI test.
Local testing in viewer:
scaling_boxes_test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 self-assigned this Jan 14, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 14, 2020
@dhruvbatra
Copy link
Contributor

Will be useful for domain randomization.

Also, it's raining cheeseboxes :-).

Copy link
Contributor

@msbaines msbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The physics config parsing code is getting large enough that it may be time to pull it out of ResourceManager.cpp. We may also want to consider writing a code generator since the code is all following the same template.

@aclegg3
Copy link
Contributor Author

aclegg3 commented Jan 17, 2020

The physics config parsing code is getting large enough that it may be time to pull it out of ResourceManager.cpp. We may also want to consider writing a code generator since the code is all following the same template.

Great point, I was thinking the same thing while writing this code. 😄

@aclegg3 aclegg3 merged commit 9777c45 into master Jan 17, 2020
@aclegg3 aclegg3 deleted the phys_obj_scaling_config branch January 17, 2020 23:03
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* Add configurable physics object scaling

* Added test for visual and collision scaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants