Fix STATIC RigidObject interactions. #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orld_ instead of btRigidBody
… testing. Fixed color/normals for transform_box asset.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 62.64% 62.96% +0.32%
==========================================
Files 162 162
Lines 7667 7734 +67
Branches 84 84
==========================================
+ Hits 4803 4870 +67
Misses 2864 2864
Continue to review full report at Codecov.
|
bigbike
approved these changes
Mar 20, 2020
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* Fixed STATIC MotionType RigidObject by adding btCollisionObject to bWorld_ instead of btRigidBody. * Default white light color. * Modified color/normals for transform_box asset. * C++ unit tests improved for changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As shown in the before frames below,
MotionType::STATICRigidObjects were not properly responding to collisions. This changes fixes the issue by adding a static collision object to the world in pace of a rigid body whenMotionType::STATICis requested.Other minor changes:
transform_box.glbasset to include material colors and outfacing normals.LightInfoobjects to white.How Has This Been Tested
Added a new C++ test to check for this issue.
Practical Example:
Before:
After:
Example of new test:
Before fix:
After fix:
Types of changes
Checklist