Fix coordinate transforms #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
OK, so once this is in I'll do the corresponding change in #57. |
11 tasks
msavva
approved these changes
May 30, 2019
There was a problem hiding this comment.
Thanks @erikwijmans -- this PR fixes the buried issue and makes things far more readable! Left a couple of small doc comments, but otherwise LGTM! Let's land it. 👍
|
Issues addressed |
Looks great -- let's land it! |
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
Fix weird coordinate transform Fix geo::CoordinateFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#57 raised that the transform on the meshes is weird! This is actually a bug that, due to serendipity, actually works.
This PR fixes this by first fixing
CoordinateFrame::rotationWorldToFrame, using that to implement aCoordinateFrame::rotationFrameToWorld, then using that to rotate the mesh to ESP coordinates.CC: @mosra (no need for review, just tagging for visibility)
How Has This Been Tested
Via pytest (rendering tests would complain) and via viewer
Types of changes