Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for Python 3.9 #1062

Closed
3 tasks done
shagunsodhani opened this issue Oct 14, 2020 · 10 comments
Closed
3 tasks done

[Feature Request] Add support for Python 3.9 #1062

shagunsodhani opened this issue Oct 14, 2020 · 10 comments
Assignees
Labels
enhancement Enhanvement request

Comments

@shagunsodhani
Copy link
Contributor

shagunsodhani commented Oct 14, 2020

🚀 Feature Request

Add support for Python 3.9

Motivation

  • Python 3.9 is available. We should consider supporting it.

Pitch

  • Check if CI/Conda supports 3.9.
  • Run the tests with python 3.9 and check what breaks.
  • Fix whatever breaks (if applicable).

Are you willing to open a pull request? (See CONTRIBUTING)

Yes

Additional context

NA

@shagunsodhani shagunsodhani added the enhancement Enhanvement request label Oct 14, 2020
@shagunsodhani
Copy link
Contributor Author

cc @jieru-hu

@shagunsodhani
Copy link
Contributor Author

Regarding 1. python 3.9 is not available right now. Retry in a few days.

@omry
Copy link
Collaborator

omry commented Oct 15, 2020

Once you get it to work, can you also send a PR against OmegaConf to add 3.9? the CI there is much simpler.

@johnmdilley
Copy link

Attempting to run on Python 3.9 (Windows) results in the following for me (same code works on Python 3.8):

C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\core\plugins.py:202: UserWarning: 
	Error importing 'hydra._internal.core_plugins.importlib_resources_config_source'.
	Plugin is incompatible with this Hydra version or buggy.
	Recommended to uninstall or upgrade plugin.
		ModuleNotFoundError : No module named 'importlib_resources'
  warnings.warn(
Traceback (most recent call last):
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\utils.py", line 198, in run_and_report
    return func()
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\utils.py", line 320, in <lambda>
    lambda: Hydra.create_main_hydra2(
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\hydra.py", line 73, in create_main_hydra2
    config_loader: ConfigLoader = ConfigLoaderImpl(
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\config_loader_impl.py", line 79, in __init__
    self.repository: ConfigRepository = ConfigRepository(
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\config_repository.py", line 22, in __init__
    source_type = SourcesRegistry.instance().resolve(scheme)
  File "C:\Users\johndi\AppData\Local\Programs\Python\Python39\lib\site-packages\hydra\_internal\sources_registry.py", line 29, in resolve
    raise ValueError(
ValueError: No config source registered for schema pkg, supported types : [file, structured]

Process finished with exit code 1

@shagunsodhani
Copy link
Contributor Author

I have a PR on this. Will push later today

@omry
Copy link
Collaborator

omry commented Dec 12, 2020

Thanks for reporting @johnmdilley, we will have a fix for it soon.

@shagunsodhani , once your fix is accepted, can you also backport it to the 1.0_branch?

@shagunsodhani
Copy link
Contributor Author

Following plugins do not support 3.9:

  1. Ray Launcher: Python 3.9 wheel ray-project/ray#11287

@omry
Copy link
Collaborator

omry commented Dec 12, 2020

Ok. can you leave a comment in its setup.py with a link to that issue?

@shagunsodhani
Copy link
Contributor Author

@johnmdilley The fix has landed in master now.

@shagunsodhani
Copy link
Contributor Author

Closed in #1197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhanvement request
Projects
None yet
Development

No branches or pull requests

3 participants