Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.9 #1063

Closed
wants to merge 1 commit into from
Closed

Add support for Python 3.9 #1063

wants to merge 1 commit into from

Conversation

shagunsodhani
Copy link
Contributor

Motivation

Add support for Python 3.9

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI

Related Issues and PRs

#1062

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2020
@omry
Copy link
Collaborator

omry commented Oct 15, 2020

Could have been a good move to try running it locally in conda with 3.9 before you try to run it in CI. :)

@omry
Copy link
Collaborator

omry commented Oct 19, 2020

file again when you think it can work, it bothers me to have this failing PR here for a long time without a clear action plan.

@omry omry closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants