Support for Python 3.9 on 1.0 branch #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
omry
requested changes
Dec 18, 2020
plugins/hydra_ax_sweeper/setup.py
Outdated
| @@ -18,6 +18,7 @@ | |||
| "License :: OSI Approved :: MIT License", | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| # "Programming Language :: Python :: 3.9", | |||
There was a problem hiding this comment.
Why is this commented out?
If there is a task, remove this line.
| @@ -19,6 +19,7 @@ | |||
| "Programming Language :: Python :: 3.6", | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| # "Programming Language :: Python :: 3.9", | |||
plugins/hydra_ray_launcher/setup.py
Outdated
| @@ -17,6 +17,7 @@ | |||
| "License :: OSI Approved :: MIT License", | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| # "Programming Language :: Python :: 3.9", | |||
* Fix importlib error when using py3.9 * Fix lint errors * Add a method to match lines based on regex * fix lint error * bump hydra version in discovery test plugin * Add python 3.9 in setup.py * Skip python 3.9 tests on windows * use assert_text_same when lengths of actual and expected output do not match * Remove dependency on hydra version * Check python version to decide if importlib_resources should be imported * Update the install script for plugins to reflect support for python 3.9 * pin virtualenv to 20.0.33 for windows * Fix lint error * Enable CI for 3.9 on windows * Update circle ci config * Update circle ci config * Fix issues with windows * Skip Ray test for Python 3.9 * Incorporate feedback * Fix circleci config * Fix lint errors * Fix circleci config * Fix some ci errors * Fix lint error * Fix lint error * Update setup.py for some plugins * Disable windows 9 support * Ax plugin doesnt support 3.9 for now * Nevergrad python 3.9 support depends on Scikit-learn * Add news entries * Accidentally removed support for optuna on windows * Incorporate feedback * Disable windows test for optuna
shagunsodhani
force-pushed
the
1.0_branch_py39
branch
from
091cb62
to
677d9ff
Compare
omry
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support for Python 3.9 for 1.0 branch.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)
#1062