Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pytest imports to reduce tests boilerplate #1445

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Cleanup pytest imports to reduce tests boilerplate #1445

merged 1 commit into from
Mar 3, 2021

Conversation

omry
Copy link
Collaborator

@omry omry commented Mar 3, 2021

switching the codebase from using

import pytest

to

from pytest import mark, param, raises, warns

To eliminate usage of pytest. everywhere in tests, making lines shorter and code formatting cleaner.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2021
@omry
Copy link
Collaborator Author

omry commented Mar 3, 2021

cc @odelalleau ,@jieru:
May likely cause conflicts for tests in outstanding diffs.

@omry omry merged commit 9bf7800 into master Mar 3, 2021
@omry omry deleted the pytest branch March 3, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants