Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hydra.runtime.choices during multirun #2124

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

jieru-hu
Copy link
Contributor

@jieru-hu jieru-hu commented Apr 2, 2022

closes #1882

The particular line of code deleted in this PR is redundant and actually override the correct value to an outdated one.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2022
@jieru-hu jieru-hu requested review from Jasha10 and pixelb April 2, 2022 01:57
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jieru-hu jieru-hu merged commit 8e1a9f9 into facebookresearch:main Apr 4, 2022
@jieru-hu jieru-hu deleted the i1882 branch April 4, 2022 16:26
@Jackwaggon33

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?] hydra.runtime.choices seems not to reflect current choice during multi-run
5 participants