Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when build docker #130

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

QIU-Shuo
Copy link
Contributor

@QIU-Shuo QIU-Shuo commented Jun 1, 2022

Patch Description
Hi, the current Dockerfile cannot build successfully, I made a few fix for it.

  1. Limit the max version for hydra-core, since hydra-core 1.2 will require omegaconf~=2.2 and raise a conflict.
  2. Fix error in line 35.
  3. I didn't encounter issue Public GPG key error NVIDIA/nvidia-container-toolkit#258, and the workaround in line 8-9 raises an file not found error for me. They have probably fixed the docker, but I am not sure about this.

Testing steps
docker build -f Dockerfile .

@QIU-Shuo QIU-Shuo changed the title Dockerfilefix Fix errors when build docker Jun 1, 2022
Copy link
Contributor

@suchenzang suchenzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@suchenzang suchenzang merged commit 821b43a into facebookresearch:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants