Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when build docker with Dockerfile #129

Closed
QIU-Shuo opened this issue Jun 1, 2022 · 2 comments
Closed

Error when build docker with Dockerfile #129

QIU-Shuo opened this issue Jun 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@QIU-Shuo
Copy link
Contributor

QIU-Shuo commented Jun 1, 2022

🐛 Bug

  1. hydra-core 1.2 requires omegaconf~=2.2 and raise a conflict: error: omegaconf 2.1.1 is installed but omegaconf~=2.2 is required by {'hydra-core'}
  2. Line 35 will raie an error: fatal: unable to access 'https://github.git/': Could not resolve host: github.git
  3. I didn't encounter issue Public GPG key error NVIDIA/nvidia-container-toolkit#258, and the workaround in line 8-9 raises an file not found error for me. They have probably fixed the docker, but I am not sure about this.

I have submit a PR for your reference: #130.

To Reproduce

docker build -f Dockerfile .

Code sample

Expected behavior

Successfully built.

Environment

  • metaseq Version (e.g., 1.0 or master): main
  • PyTorch Version (e.g., 1.0) As specified in dockerfile
  • OS (e.g., Linux, Windows, MacOS): As specified in dockerfile
  • How you installed metaseq (pip, source): As specified in dockerfile
  • Build command you used (if compiling from source): As specified in dockerfile
  • Python version: As specified in dockerfile
  • CUDA/cuDNN version: As specified in dockerfile
  • GPU models and configuration: A100
  • Any other relevant information:

Additional context

@QIU-Shuo QIU-Shuo added the bug Something isn't working label Jun 1, 2022
@suchenzang
Copy link
Contributor

@QIU-Shuo did your PR fix your issue mentioned here? We don't use docker in our workflows yet, so this isn't a feature we're testing right now.

@QIU-Shuo
Copy link
Contributor Author

QIU-Shuo commented Jun 9, 2022

Thank you for your quick merge! Yes It can now built sucussfully. However I found several other problems while exploring metaseq inside docker, I will prepare another PR when I figure out how to solve them.

@QIU-Shuo QIU-Shuo closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants