Avoid two candidates with same value. #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Supposed to fix #976 |
teytaud
commented
Jan 7, 2021
| num_determinism_failures = 0 | ||
| while candidate.get_value_hash() in self._forbidden_value: | ||
| num_determinism_failures += 1 | ||
| if num_determinism_failures >= 10: |
There was a problem hiding this comment.
with this limit we get rid of the risk of infinite / super-long loop.
Still, it would be better to have the auxiliary optimizer (which ensures that we do not go too far) - but Roma was not built in a single day.
teytaud
commented
Jan 7, 2021
| @@ -78,7 +78,7 @@ def square2(m: tp.Any) -> float: | |||
| model.constraint1 = pyomo.Constraint(rule=lambda m: m.x >= 2) | |||
|
|
|||
| func = core.Pyomo(model) | |||
| optimizer = ng.optimizers.OnePlusOne(parametrization=func.parametrization, budget=100) | |||
| optimizer = ng.optimizers.OnePlusOne(parametrization=func.parametrization, budget=20) | |||
There was a problem hiding this comment.
This shows that we are faster than previously.
teytaud
commented
Jan 7, 2021
| @@ -146,7 +146,7 @@ def axis(self) -> tp.Optional[tp.Tuple[int, ...]]: | |||
| def _apply_array(self, arrays: tp.Sequence[np.ndarray]) -> np.ndarray: | |||
| assert len(arrays) == 1 | |||
| data = arrays[0] | |||
| axis = tuple(range(data.dim)) if self.axis is None else self.axis | |||
| axis = tuple(range(len(data))) if self.axis is None else self.axis | |||
There was a problem hiding this comment.
I don't understand why this was not caught earlier...
jrapin
requested changes
Jan 8, 2021
There was a problem hiding this comment.
there are too many side effects, I'll need time to analyze this:
- it's a breaking change (people with noisy function, including using noisy optimizers will by default get deterministic behavior)
- it can explode memory for both long runs and huge parametrization
- it's using the value hash which probably needs a lot of revamp because it is hard to implement (leading to issues when adding new parametrizations), and probably too inefficient.
Using request changes to make sure we do not merge it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Current concerns that need to be tackled (for discussion/tracking):
How Has This Been Tested (if it applies)
Checklist